[PATCH 1/14] [x86_64] Vector math functions (vector cos)

[Andrew Senkevich]

2015-06-04 19:50 GMT+03:00 Joseph Myers <joseph@codesourcery.com>:
> On Mon, 25 May 2015, Andrew Senkevich wrote:
>
>> > As far as I can tell, if you use --disable-multi-arch, then these files
>> > won't be built into libmvec, and nothing else will provide the
>> > _ZGVbN2v_cos and _ZGVeN8v_cos symbols.  See other multiarch code for
>> > examples of how such things are handled - typically, the file outside the
>> > multiarch directory implements things for an always-supported architecture
>> > variant (in this case, that would be a variant guaranteed to be supported
>> > if the given entry point gets called), then, in the multiarch directory,
>> > there are the implementations for other variants, and a file with the same
>> > name as that outside the multiarch directory, that (a) provides the IFUNC
>> > resolver and (b) defines some macros before #including the file in the
>> > directory above, so that the basic version of the function gets defined
>> > under a different name.
>>
>> Hi, Joseph, updated patch is attached. Is it ok?
>
> OK provided you've tested this both with and without --disable-multi-arch.

Thank you for review, of course both cases were tested.


--
WBR,
Andrew