[PATCH] getauxval: fix crash on systems without HAVE_AUX_VECTOR
Roland McGrath
roland@hack.frob.com
Mon Apr 4 19:38:00 GMT 2016
> On 02 Apr 2016 12:57, Samuel Thibault wrote:
> > Systems without HAVE_AUX_VECTOR have GLRO(dl_auxv) == NULL, and
> > getauxval would thus crash.
>
> assuming this is for GNU/hurd
Yes.
> should this just be under HAVE_AUX_VECTOR ? seems like we shouldn't
> even bother defining/exporting dl_auxv at all if it's disabled. then
> we wouldn't run into more latent problems like this at run time -- it
> would be a build failure.
Agreed.
> in looking at other uses of dl_auxv, why isn't _dl_sysdep_start an
> issue too ? rtld.c:_dl_start_final always calls that, and that func
> always walks GLRO(dl_auxv).
You are looking at elf/dl-sysdep.c, not sysdeps/mach/hurd/dl-sysdep.c.
More information about the Libc-alpha
mailing list