[PATCH] Add missing include to posix/tst-dir.c

Florian Weimer fw@deneb.enyo.de
Mon Feb 22 15:23:00 GMT 2016


* Tulio Magno Quites Machado Filho:

> Florian Weimer <fw@deneb.enyo.de> writes:
>
>> * Tulio Magno Quites Machado Filho:
>>
>>> A recent change to posix/tst-dir.c started to use macros from
>>> libc-internal.h but didn't include it, causing build issues.
>>>
>>> 2016-02-22  Tulio Magno Quites Machado Filho  <tuliom@linux.vnet.ibm.com>
>>>
>>> 	* posix/tst-dir.c: Include libc-internal.h.
>>
>> I have never seen a need to include <libc-internal.h> like this
>> before.  How are you building the tests that you need this?
>
> There is nothing special:
> configure --prefix=/usr --with-cpu=power8 --enable-add-ons
> make
> make -k check
>
> I'm using GCC 4.8.4.

Thanks, found the difference, it's due to the #includes in
sysdeps/i386/nptl/tls.h and sysdeps/x86_64/nptl/tls.h.  Perhaps we can
get rid of that to avoid future such breakage.

Patch is fine.



More information about the Libc-alpha mailing list