[PATCH v7 08/13] ARC: Linux ABI

[Adhemerval Zanella]

On 06/07/2020 15:33, Vineet Gupta wrote:
> On 7/2/20 1:44 PM, Adhemerval Zanella via Libc-alpha wrote:
>>
>>
>> On 15/06/2020 17:14, Vineet Gupta via Libc-alpha wrote:
>>> ---
>>
>> LGTM with soem nits regarding indentation.
>>
>> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
> 
>>> +
>>> +#ifdef __USE_MISC
>>> +extern int cacheflush (void *__addr, const int __nbytes, const int __op) __THROW;
>>> +#endif
>>> +
>>> +__END_DECLS
>>> +
>>> +#endif
>>
>> Ok (althoug the const int is not really required here).
> 
> Removed.
> 
>>
>>> diff --git a/sysdeps/unix/sysv/linux/arc/sys/ucontext.h b/sysdeps/unix/sysv/linux/arc/sys/ucontext.h
> ..
>>> +typedef struct
>>> +  {
>>> +    unsigned long int __pad;
>>> +    unsigned long int __bta;
>>> +    unsigned long int __lp_start, __lp_end, __lp_count;
>>> +    unsigned long int __status32, __ret, __blink;
>>> +    unsigned long int __fp, __gp;
>>> +    unsigned long int __r12, __r11, __r10, __r9, __r8, __r7;
>>> +    unsigned long int __r6, __r5, __r4, __r3, __r2, __r1, __r0;
>>> +    unsigned long int __sp;
>>> +    unsigned long int __r26;
>>> +    unsigned long int __r25, __r24, __r23, __r22, __r21, __r20;
>>> +    unsigned long int __r19, __r18, __r17, __r16, __r15, __r14, __r13;
>>> +    unsigned long int __efa;
>>> +    unsigned long int __stop_pc;
>>> +    unsigned long int __r30, __r58, __r59;
>>> +  } mcontext_t;
>>> +
>>> +/* Userlevel context.  */
>>> +typedef struct ucontext_t
>>> +  {
>>> +    unsigned long int __uc_flags;
>>> +    struct ucontext_t *uc_link;
>>> +    stack_t uc_stack;
>>> +    mcontext_t uc_mcontext;
>>> +    sigset_t uc_sigmask;
>>> +  } ucontext_t;
>>> +
>>> +#endif
>>
>> The indentation is not really following the GNU guidelines here.
> 
> So, these need to start at column #1, per [1] ?
> 
> I don't mind fixing it but all other implementations of this file have the format
> exactly like above.

I don't have a strong opinion here in fact, I think usually developers just
import the code from kernel and do some name adjustments to fit on glibc.

> 
> [1] https://www.gnu.org/prep/standards/html_node/Formatting.html#Formatting
> 
> 
>>> diff --git a/sysdeps/unix/sysv/linux/arc/sys/user.h b/sysdeps/unix/sysv/linux/arc/sys/user.h
> ..
>>> +
>>> +struct user {
>>> +  int dummy;
>>> +};
>>> +
>>> +#endif
>>
>> Same as before.
> 
> This is fixed to start at column 1.
>