This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

RE: [PATCH] Import setenv and unsetenv from gnulib

From: Anton Kolesov <Anton dot Kolesov at synopsys dot com>
To: Yao Qi <qiyaoltc at gmail dot com>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Francois Bedard <Francois dot Bedard at synopsys dot com>, Sergio Durigan Junior <sergiodj at redhat dot com>
Date: Fri, 7 Jul 2017 09:35:04 +0000
Subject: RE: [PATCH] Import setenv and unsetenv from gnulib
Authentication-results: sourceware.org; auth=none
References: <87shid8rt3.fsf@redhat.com> <20170703162737.8386-1-Anton.Kolesov@synopsys.com> <CAH=s-POJzGx1Ab28a56ru2S6jHugH-gikJJgFziiR4ZRSc0-Tg@mail.gmail.com> <39A54937CC95F24AA2F794E2D2B66B135876DD39@DE02WEMBXB.internal.synopsys.com> <86bmow64f6.fsf@gmail.com>

> They are not regressions to me.
> 
> > Selftests pass on x86_64-linux. On Windows with this patch there is a
> > failure in iconv sefltest, which seems unrelated (was present even
> > when I've tried to use putenv directly instead of importing gnulib module).
> 
> Thanks for running tests on Windows.  Your patch is safe to go in.
> Please push it in.

Just to be clear, I've run regression tests on a Linux system, on Windows I've run
only the selftests. 

Anton


> 
> --
> Yao (齐尧)

References:
- Re: [PATCH] Fix build breakage on MinGW due to missing setenv
  - From: Sergio Durigan Junior
- [PATCH] Import setenv and unsetenv from gnulib
  - From: Anton Kolesov
- Re: [PATCH] Import setenv and unsetenv from gnulib
  - From: Yao Qi
- RE: [PATCH] Import setenv and unsetenv from gnulib
  - From: Anton Kolesov
- Re: [PATCH] Import setenv and unsetenv from gnulib
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]